Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup auto release workflow #313

Merged
merged 6 commits into from
Oct 14, 2020
Merged

Setup auto release workflow #313

merged 6 commits into from
Oct 14, 2020

Conversation

smoia
Copy link
Member

@smoia smoia commented Oct 9, 2020

Closes #311 and closes #239

Second attempt to integrate auto as a workflow, this time as a GitHub action. IF this works, we have a great automated workflow from PR merge to Pypi package (with the other workflow).

Proposed Changes

  • Add .autorc configuration file
  • Add github workflow that * should * retrieve the latest version of auto (might not be elegant) and then run it
  • Add a couple of badges.

I can't wait to see if this works. So exciting!

@hipstersmoothie, could you please have a look at this PR?
@yarikoptic and @jwodder, you could have a look into this too - if you implemented a different solution I'd like to compare them, and otherwise if this works it should help you with datalad/datalad#4999 and dandi/dandi-cli#252!

@smoia smoia added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Oct 9, 2020
@smoia smoia requested review from tsalo and eurunuela October 9, 2020 21:22
@smoia smoia self-assigned this Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020 •
edited
Loading

Codecov Report

Merging #313 into master will decrease coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   95.85%   94.78%   -1.07%     
==========================================
  Files          29        9      -20     
  Lines        2314      844    -1470     
==========================================
- Hits         2218      800    -1418     
+ Misses         96       44      -52
Impacted Files Coverage Δ
D:/a/1/s/phys2bids/interfaces/txt.py
D:/a/1/s/phys2bids/tests/test_utils.py
D:/a/1/s/phys2bids/utils.py
D:/a/1/s/phys2bids/tests/test_physio_obj.py
D:/a/1/s/phys2bids/bids.py
D:/a/1/s/phys2bids/viz.py
D:/a/1/s/phys2bids/tests/test_bids.py
D:/a/1/s/phys2bids/due.py
D:/a/1/s/phys2bids/phys2bids.py
D:/a/1/s/phys2bids/tests/test_viz.py
... and 10 more

@smoia
Copy link
Member Author

smoia commented Oct 9, 2020

(BTW, I set up the GH_TOKEN as an organisation secret. Is that right?)

eurunuela
eurunuela reviewed Oct 10, 2020
View reviewed changes
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this looks good. I don't think I'm the best person to review this PR though.

tsalo
tsalo reviewed Oct 10, 2020
View reviewed changes
.autorc
"overwrite": true
},
{
"name": "Minormod-breaking",
Copy link
Member

@tsalo tsalo Oct 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still valid when phys2bids is past alpha (i.e., 1.0.0+)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove it, but honestly it' mainly there to maintain the same configuration across physiopy. I doubt we'll ever use that label!

tsalo
tsalo approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is basically the same as @eurunuela's. I read through everything and it makes sense, but since I'm not familiar with auto, I'm not sure how valuable my review is.

(BTW, I set up the GH_TOKEN as an organisation secret. Is that right?)

That seems reasonable. It looks like you need to add your personal access token to the GitHub repository's secret environmental variables. I'm not sure if organization-level secrets are automatically used for individual repositories, but it makes sense that they would be.

@smoia
Copy link
Member Author

smoia commented Oct 10, 2020 •
edited
Loading

Schermata da 2020-10-10 19-01-20
This is what I did for the secrets (They are both linked to my account)

@eurunuela
Copy link
Collaborator

I say we give this a shot if you feel comfortable with it @smoia

@smoia smoia mentioned this pull request Oct 14, 2020
Merged
@smoia
Copy link
Member Author

smoia commented Oct 14, 2020

Ok, let's try this out.

@smoia smoia merged commit 639c3a6 into physiopy:master Oct 14, 2020
@smoia smoia mentioned this pull request Oct 14, 2020
Open
@smoia
Copy link
Member Author

smoia commented Oct 19, 2020

🚀 PR was released in 2.2.1 🚀

@smoia smoia added prerelease This change is available in a prerelease. released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela left review comments

@tsalo tsalo tsalo approved these changes

Assignees

@smoia smoia

Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
3 participants
@smoia @eurunuela @tsalo